Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: test CLI test with serve --detach #722

Merged
merged 22 commits into from
Jun 18, 2024
Merged

Chore: test CLI test with serve --detach #722

merged 22 commits into from
Jun 18, 2024

Conversation

Van-QA
Copy link
Contributor

@Van-QA Van-QA commented Jun 18, 2024

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

namchuai and others added 19 commits June 17, 2024 11:07
@namchuai @louis-jan
feat: add model event
805ed41 
Signed-off-by: James <[email protected]>
@namchuai @louis-jan
fix test cases
19169fd 
Signed-off-by: James <[email protected]>
@louis-jan
fix: tests
cc70f5a
@Van-QA
chore: add test_data fake config
4004534
@Van-QA
fix: correct test_data setup
e2635a4
@Van-QA
fix: correct test_data setup
732c249
@Van-QA
fix: temp disable for further investigation
e68f573
@namchuai @Van-QA
feat: add model event
ffa47d3 
Signed-off-by: James <[email protected]>
@namchuai @Van-QA
fix test cases
6739209 
Signed-off-by: James <[email protected]>
@louis-jan @Van-QA
fix: tests
1e6e94a
@Van-QA
chore: add test_data fake config
8c8d55a
@Van-QA
fix: correct test_data setup
ced10b9
@Van-QA
fix: correct test_data setup
f3ba691
@Van-QA
fix: temp disable for further investigation
16a8609
@Van-QA
Merge remote-tracking branch 'origin/chore/fix_test-data' into chore/…
732c82f 
…fix_test-data
@Van-QA
Merge branch 'refs/heads/dev' into chore/fix_test-data
fc6524e 
# Conflicts:
#	cortex-js/src/infrastructure/commanders/test/helpers.command.spec.ts
@Van-QA
fix: serve --detach
cb11e6b
@Van-QA
Merge branch 'refs/heads/dev' into chore/fix_test-data
4cc1fd7
chore: temporally disable failed test due to test_data folder in CI n…
ac91deb 
…ot found
@Van-QA Van-QA marked this pull request as ready for review June 18, 2024 06:19
@Van-QA Van-QA requested a review from louis-jan June 18, 2024 06:34
@Van-QA Van-QA merged commit e421676 into dev Jun 18, 2024
1 check passed
@Van-QA Van-QA deleted the chore/fix_test-data branch June 18, 2024 06:35
cahyosubroto pushed a commit that referenced this pull request Jun 26, 2024
@Van-QA @namchuai
@louis-jan @irfanpena
Chore: test CLI test with serve --detach (#722)
1135657 
Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>
Co-authored-by: Van-QA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Van-QA @louis-jan @namchuai